Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: improve readability #6190

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Refactor: improve readability #6190

merged 1 commit into from
Dec 17, 2024

Conversation

sazk07
Copy link
Contributor

@sazk07 sazk07 commented Nov 27, 2024

Edit assignment inside condition check to a separate step

@sazk07
Refactor: improve readability
00592a0 
Edit assignment inside condition check to a separate step
@wesleytodd
Copy link
Member

Is this just a new PR from this? #6173

@sazk07
Copy link
Contributor Author

sazk07 commented Dec 9, 2024

Is this just a new PR from this? #6173

@wesleytodd
yes . @UlisesGascon asked to backport the PR to v4 #6173 (comment)

@wesleytodd
Copy link
Member

Thanks! I just wanted to make sure since I was sure we had merged this already. Seems good to land then.

@wesleytodd wesleytodd merged commit 2041584 into expressjs:4.x Dec 17, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjohansebas bjohansebas bjohansebas approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sazk07 @wesleytodd @bjohansebas